[jira] [Commented] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123906#comment-16123906 ]

Jacques Le Roux commented on OFBIZ-9530:
----------------------------------------

Thanks Kyra,

Your patch is in
trunk r1804843
R16.11 r1804845

I did not backport in earlier branches because I got a weird conflict in PaymentGatewayServices and it's not that a big issue

> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-9530
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9530
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Kyra Pritzel-Hentley
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: OFBIZ-9530_PaymentGatewayServices_bugfix.patch, OFBIZ-9530_PaymentGatewayServices_bugfix.patch
>
>
> In the method _processAuthResult_  line 1889 there is an empty if-statement for the case that authResult is null. It seems like somebody was planning to cover the case but forgot to add code.
> I would suggest to return a service error when the authResult is null since otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>            
>             if (authResultOk) {
>                 orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
>             } else {
>                 orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Loading...