[jira] [Commented] (OFBIZ-12177) Possibly currency display bug in "Find Invoices"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12177) Possibly currency display bug in "Find Invoices"

ASF subversion and git services (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293630#comment-17293630 ]

Priya Sharma commented on OFBIZ-12177:
--------------------------------------

Hi Andrei / All,

Added a patch wherein I have removed the additional conversion operation on the total amount.

Since the method "InvoiceWorker.getInvoiceTotal" takes care of the conversion, it is redundant to convert it again on the screen, which results in mismatch of the currency and the amount.

Please review and let me know if this works.

> Possibly currency display bug in "Find Invoices"
> ------------------------------------------------
>
>                 Key: OFBIZ-12177
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12177
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Andrei Stan
>            Assignee: Priya Sharma
>            Priority: Minor
>         Attachments: Captură de ecran de la 2021-02-15 17-31-06.png, Captură de ecran de la 2021-02-15 17-33-34.png, OFBIZ-12177.patch
>
>
> h4. - in the page with the "Invoices List", the numbers are wrong for "Total: EUR 820.2773" of "demo11001".
> h4. Steps to generate:
> Open https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices
> - see that invoice "demo11001" has the Total of *EUR* 820.2773.
> - click on the Invoice id "demo11001"
> - if you look at payments, we can see that a payment of *EUR* 543.23 was made and applied.
>  * in the invoice Overview we can see the correct currency $ is with the amount of 820.2773 -> https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=demo10001
> I think the bug is this: 
>  * it should display USD 820.2773 or *EUR* 543.23 in the "Invoices List (find invoieces)" page  ?!?
>  * in the project file "../applications/datamodel/data/demo/AccountingDemoData.xml" you
>  * can see the converting factor: 
>  **
> <UomConversionDated uomId="USD" uomIdTo="EUR" fromDate="2001-01-01 00:00:00.0" conversionFactor="0.7"/>
> <UomConversionDateduomId="EUR"uomIdTo="USD"fromDate="2001-01-01 00:00:00.0"conversionFactor="1.5"/>  => *EUR 543.23 = $ 820.2773*
>  
>  * as an enhancement for the payments in other currencies i think it would be usefull to display the Total amount of the invoice with it's currency alogside the amount of total payments in other currency, applied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)