Possible Issue - appendOrderItem Service

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible Issue - appendOrderItem Service

darrell73s
Hi Folks,

I'm running 12.04.02,

I'm using the "appendOrderItem" service in the order application. The service definition allows for an optional Map of order item attributes called "itemAttributesMap". However, the addItemToApprovedOrder method in OrderServices isn't using that map from the service context, thus the order item attributes aren't being added to the item when it's added to the order.

I've checked the addItemToApprovedOrder method in the trunk OrderServices, and the itemAttributesMap is not being utilized there either. I can fix and submit a patch (see implementation in updateOrderItems service), but wanted to ensure this wasn't a design choice.

Thanks,
Darrell
Reply | Threaded
Open this post in threaded view
|

Re: Possible Issue - appendOrderItem Service

Adrian Crum-3
Please create a Jira issue.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 3/10/2014 7:10 AM, darrell73s wrote:

> Hi Folks,
>
> I'm running 12.04.02,
>
> I'm using the "appendOrderItem" service in the order application. The
> service definition allows for an optional Map of order item attributes
> called "itemAttributesMap". However, the addItemToApprovedOrder method in
> OrderServices isn't using that map from the service context, thus the order
> item attributes aren't being added to the item when it's added to the order.
>
> I've checked the addItemToApprovedOrder method in the trunk OrderServices,
> and the itemAttributesMap is not being utilized there either. I can fix and
> submit a patch (see implementation in updateOrderItems service), but wanted
> to ensure this wasn't a design choice.
>
> Thanks,
> Darrell
>
>
>
> --
> View this message in context: http://ofbiz.135035.n4.nabble.com/Possible-Issue-appendOrderItem-Service-tp4648984.html
> Sent from the OFBiz - User mailing list archive at Nabble.com.
>
Reply | Threaded
Open this post in threaded view
|

Re: Possible Issue - appendOrderItem Service

Christian Carlow-OFBizzer
This reminded me of my almost forgotten OFBIZ-5423
<https://issues.apache.org/jira/browse/OFBIZ-5423> I created because the
same form does not allow variant selections when virtual products are
added which is required when adding items to the shopping cart before
the order exists.  Therefore the virtual product itself is added to the
order which isn't supposed to be allowed to happen. I mentioned this to
provide another example where this form is lacking and express
likelihood of it containing more issues such as the one you mentioned.

On 03/10/2014 09:45 AM, Adrian Crum wrote:

> Please create a Jira issue.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 3/10/2014 7:10 AM, darrell73s wrote:
>> Hi Folks,
>>
>> I'm running 12.04.02,
>>
>> I'm using the "appendOrderItem" service in the order application. The
>> service definition allows for an optional Map of order item attributes
>> called "itemAttributesMap". However, the addItemToApprovedOrder
>> method in
>> OrderServices isn't using that map from the service context, thus the
>> order
>> item attributes aren't being added to the item when it's added to the
>> order.
>>
>> I've checked the addItemToApprovedOrder method in the trunk
>> OrderServices,
>> and the itemAttributesMap is not being utilized there either. I can
>> fix and
>> submit a patch (see implementation in updateOrderItems service), but
>> wanted
>> to ensure this wasn't a design choice.
>>
>> Thanks,
>> Darrell
>>
>>
>>
>> --
>> View this message in context:
>> http://ofbiz.135035.n4.nabble.com/Possible-Issue-appendOrderItem-Service-tp4648984.html
>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>